-
-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Run pre-commit hooks in parallel #1190
base: master
Are you sure you want to change the base?
Conversation
dbd7aa9
to
9ef682f
Compare
Oh good catch. If anything I would remove parallel prettier. I think the vue version has special handling for single file components. I'm not sure regular prettier does. |
my vague memory of why we added this feature was people were sending us PRs with unformatted code. VSC IDE that I have setup formats on save so I don't need it personally, but it's useful for the general population of less sophisticated developers. I would say let's drop the call to prettier in npm and see if this causes problems on PRs. |
How about running prettier only on changed files? I think there should be some way to do that |
Great idea. Apparently there's a lint staged hook |
I installed |
Sure. |
Description